jtuglu1 commented on code in PR #18855: URL: https://github.com/apache/druid/pull/18855#discussion_r2634346897
########## indexing-service/src/main/java/org/apache/druid/indexing/common/task/RowFilter.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexing.common.task; + +import org.apache.druid.data.input.InputRow; +import org.apache.druid.segment.incremental.ThrownAwayReason; + +import javax.annotation.Nullable; +import java.util.function.Predicate; + +/** + * A filter for input rows during ingestion that can report the reason for rejection or null for acceptance. + * This is similar to {@link Predicate} but returns the rejection reason instead of just a boolean. + */ +@FunctionalInterface +public interface RowFilter +{ + /** + * Tests whether the given row should be accepted. + * + * @param row the input row to test + * @return null if the row should be accepted, or the {@link ThrownAwayReason} if the row should be rejected + */ + @Nullable + ThrownAwayReason test(InputRow row); Review Comment: I made sure we return a primitive enum for a reason (same as the prior stack-allocated boolean) – I would prefer to not do object allocation on the hotpath. This code is called in a tight-loop in latency-critical places like streaming ingestion. The more allocs we do in that loop slows things down quite a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
