abhishekrb19 opened a new pull request, #18883:
URL: https://github.com/apache/druid/pull/18883

   Jetty recommends 
[getReadyThreads()](https://javadoc.jetty.org/jetty-12/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getIdleThreads())
 and 
[getUtilizedThreads()](https://javadoc.jetty.org/jetty-12/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getBusyThreads())
 instead of `getIdleThreads()` and `getBusyThreads()`.  The former (and the new 
metrics derived from them) are intended to capture the portion of the thread 
pool that is actually available for serving requests (short, transient jobs), 
while
   the latter also capture the state of internal system threads that are 
reserved and/or leased for internal Jetty mechanics. 
   
   I noticed on busy servers with sustained query load where the “busy” thread 
count appeared to be constantly saturated, likely because threads leased for 
thread pool maintenance were being deprioritized even though "isLowOnThreads" 
was not 1.
   
   It's also useful to get the utilization rate of the thread pool that's 
serving requests to understand thread pool usage patterns for different servers.
   
   Also update the documentation for the new metrics and also fixes up 
descriptions for some existing Jetty metrics.
   
   #### Release note
   Add new Jetty thread pool metrics to capture request-serving thread 
statistics: `jetty/threadPool/utilized`, `jetty/threadPool/ready` and 
`jetty/threadPool/utilizationRate`.
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] a release note entry in the PR description.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to