abhishekrb19 commented on code in PR #18870:
URL: https://github.com/apache/druid/pull/18870#discussion_r2658493365
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorReportPayload.java:
##########
@@ -30,29 +32,30 @@
public class KafkaSupervisorReportPayload extends
SeekableStreamSupervisorReportPayload<KafkaTopicPartition, Long>
{
+ @JsonCreator
public KafkaSupervisorReportPayload(
- String id,
- String dataSource,
- String topic,
- int partitions,
- int replicas,
- long durationSeconds,
- @Nullable Map<KafkaTopicPartition, Long> latestOffsets,
- @Nullable Map<KafkaTopicPartition, Long> minimumLag,
- @Nullable Map<KafkaTopicPartition, Long> minimumLagMillis,
- @Nullable Long aggregateLag,
- @Nullable DateTime offsetsLastUpdated,
- boolean suspended,
- boolean healthy,
- SupervisorStateManager.State state,
- SupervisorStateManager.State detailedState,
- List<SupervisorStateManager.ExceptionEvent> recentErrors
+ @JsonProperty("id") String id,
+ @JsonProperty("dataSource") String dataSource,
+ @JsonProperty("stream") String stream,
+ @JsonProperty("partitions") int partitions,
+ @JsonProperty("replicas") int replicas,
+ @JsonProperty("durationSeconds") long durationSeconds,
Review Comment:
Ah I see, thanks for the clarification! It makes sense to leave them as
primitives since these cannot be nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
