This is an automated email from the ASF dual-hosted git repository.
tuglu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 699335a31d6 Add tier dimension to segment/max bytes metric (#18890)
699335a31d6 is described below
commit 699335a31d66695d89d2924974ab069f5419232f
Author: jtuglu1 <[email protected]>
AuthorDate: Wed Jan 7 15:24:00 2026 -0800
Add tier dimension to segment/max bytes metric (#18890)
Add tier and priority dimensions to segments/max metric to ensure parity
with other historical-emitted segments/* metrics.
---
docs/operations/metrics.md | 2 +-
.../org/apache/druid/server/metrics/HistoricalMetricsMonitor.java | 7 ++++++-
.../apache/druid/server/metrics/HistoricalMetricsMonitorTest.java | 4 +++-
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/docs/operations/metrics.md b/docs/operations/metrics.md
index 5f3c0d864de..a1d1af43e8b 100644
--- a/docs/operations/metrics.md
+++ b/docs/operations/metrics.md
@@ -473,7 +473,7 @@ These metrics are emitted by the Druid Coordinator in every
run of the correspon
|Metric|Description|Dimensions|Normal value|
|------|-----------|----------|------------|
-|`segment/max`|Maximum byte limit available for segments.| |Varies.|
+|`segment/max`|Maximum byte limit available for segments.|`tier`,
`priority`|Varies.|
|`segment/used`|Bytes used for served segments.|`dataSource`, `tier`,
`priority`|< max|
|`segment/usedPercent`|Percentage of space used by served
segments.|`dataSource`, `tier`, `priority`|< 100%|
|`segment/count`|Number of served segments.|`dataSource`, `tier`,
`priority`|Varies|
diff --git
a/server/src/main/java/org/apache/druid/server/metrics/HistoricalMetricsMonitor.java
b/server/src/main/java/org/apache/druid/server/metrics/HistoricalMetricsMonitor.java
index b26a55ad5a3..f82887c60aa 100644
---
a/server/src/main/java/org/apache/druid/server/metrics/HistoricalMetricsMonitor.java
+++
b/server/src/main/java/org/apache/druid/server/metrics/HistoricalMetricsMonitor.java
@@ -57,7 +57,12 @@ public class HistoricalMetricsMonitor extends AbstractMonitor
@Override
public boolean doMonitor(ServiceEmitter emitter)
{
- emitter.emit(new ServiceMetricEvent.Builder().setMetric("segment/max",
serverConfig.getMaxSize()));
+ emitter.emit(
+ new ServiceMetricEvent.Builder()
+ .setDimension("tier", serverConfig.getTier())
+ .setDimension("priority",
String.valueOf(serverConfig.getPriority()))
+ .setMetric("segment/max", serverConfig.getMaxSize())
+ );
final Object2LongOpenHashMap<String> pendingDeleteSizes = new
Object2LongOpenHashMap<>();
diff --git
a/server/src/test/java/org/apache/druid/server/metrics/HistoricalMetricsMonitorTest.java
b/server/src/test/java/org/apache/druid/server/metrics/HistoricalMetricsMonitorTest.java
index 05865e0a2df..7c6fe7a95fd 100644
---
a/server/src/test/java/org/apache/druid/server/metrics/HistoricalMetricsMonitorTest.java
+++
b/server/src/test/java/org/apache/druid/server/metrics/HistoricalMetricsMonitorTest.java
@@ -70,6 +70,8 @@ public class HistoricalMetricsMonitorTest extends
EasyMockSupport
final int priority = 111;
final String tier = "tier";
+ EasyMock.expect(druidServerConfig.getTier()).andReturn(tier).once();
+
EasyMock.expect(druidServerConfig.getPriority()).andReturn(priority).once();
EasyMock.expect(druidServerConfig.getMaxSize()).andReturn(maxSize).once();
EasyMock.expect(segmentLoadDropMgr.getSegmentsToDelete()).andReturn(ImmutableList.of(dataSegment)).once();
EasyMock.expect(druidServerConfig.getTier()).andReturn(tier).once();
@@ -92,7 +94,7 @@ public class HistoricalMetricsMonitorTest extends
EasyMockSupport
monitor.doMonitor(serviceEmitter);
EasyMock.verify(druidServerConfig, segmentManager, segmentLoadDropMgr);
- serviceEmitter.verifyValue("segment/max", maxSize);
+ serviceEmitter.verifyValue("segment/max", Map.of("tier", tier, "priority",
String.valueOf(priority)), maxSize);
serviceEmitter.verifyValue(
"segment/pendingDelete",
Map.of("tier", tier, "dataSource", dataSource, "priority",
String.valueOf(priority)),
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
