gianm commented on code in PR #18886:
URL: https://github.com/apache/druid/pull/18886#discussion_r2671552690
##########
multi-stage-query/src/main/java/org/apache/druid/msq/dart/guice/DartControllerConfig.java:
##########
@@ -42,6 +43,12 @@ public class DartControllerConfig
@JsonProperty("heapFraction")
private double heapFraction = DEFAULT_HEAP_FRACTION;
+ @JsonProperty("maxRetainedReportCount")
+ private int maxRetainedReportCount = 0;
Review Comment:
I was being conservative here with the new functionality, and also thinking
that a small number might not be that useful. A cluster that gets real usage
will probably go through 10 queries pretty quickly. In a production situation
it probably makes sense to set it much higher and to have a time-based
expiration of at least a few minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
