gianm commented on code in PR #18873:
URL: https://github.com/apache/druid/pull/18873#discussion_r2677669338
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/SegmentCacheManagerFactory.java:
##########
@@ -52,11 +52,12 @@ public SegmentCacheManagerFactory(
this.jsonMapper = mapper;
}
- public SegmentCacheManager manufacturate(File storageDir)
+ public SegmentCacheManager manufacturate(File storageDir, boolean
virtualStorage)
{
- final SegmentLoaderConfig loaderConfig = new
SegmentLoaderConfig().withLocations(
- Collections.singletonList(new StorageLocationConfig(storageDir, null,
null))
- );
+ final SegmentLoaderConfig loaderConfig =
+ new SegmentLoaderConfig()
+ .setLocations(Collections.singletonList(new
StorageLocationConfig(storageDir, null, null)))
Review Comment:
I was hoping to manage more stuff through the storage locations as time goes
on and that would be a good time to unify things. The other thing that isn't
currently tracked is temporary storage of external data that has been
downloaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
