gianm commented on code in PR #18909:
URL: https://github.com/apache/druid/pull/18909#discussion_r2684320636
##########
processing/src/main/java/org/apache/druid/frame/file/FrameFileWriter.java:
##########
@@ -95,18 +107,70 @@ public static FrameFileWriter open(
compressionBuffer,
AppendableMemory.create(allocator),
AppendableMemory.create(allocator),
- byteTracker
+ byteTracker,
+ wireTransferableContext
);
}
/**
- * Write a frame.
+ * Write a batch of data to the file. If legacy frame serialization is
enabled and the RowsAndColumns can be
+ * converted to a Frame, it will be written as raw frame bytes with {@link
#MARKER_FRAME}. Otherwise, it will be
+ * written using {@link WireTransferable} with {@link #MARKER_RAC}.
*
- * @param frame the frame
+ * @param rac the RowsAndColumns to write
* @param partition partition number for a partitioned frame file, or {@link
#NO_PARTITION} for an unpartitioned file.
* Must be monotonically increasing.
*/
- public void writeFrame(final Frame frame, final int partition) throws
IOException
+ public void writeRAC(final RowsAndColumns rac, final int partition) throws
IOException
Review Comment:
Renamed it `write`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
