clintropolis commented on code in PR #18892:
URL: https://github.com/apache/druid/pull/18892#discussion_r2684544218
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/BatchAppenderator.java:
##########
@@ -835,6 +836,14 @@ private DataSegmentWithMetadata mergeAndPush(
metrics.setMergeTime(mergeTimeMillis);
log.debug("Segment[%s] built in %,dms.", identifier, mergeTimeMillis);
+ QueryableIndex index = indexIO.loadIndex(mergedFile);
+ closer.register(index);
Review Comment:
i guess we would need to change the signatures of merge/persist methods to
return some `MergeResult` or something that has both the file and extra stuff
like row count, i don't think we need to worry about that in this PR, though
maybe something to consider in a follow-up to save us from having to load the
segment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
