Fly-Style commented on code in PR #18891:
URL: https://github.com/apache/druid/pull/18891#discussion_r2685840400
##########
cloud/aws-common/src/test/java/org/apache/druid/common/aws/AWSClientUtilTest.java:
##########
@@ -33,75 +31,79 @@ public class AWSClientUtilTest
@Test
public void testRecoverableException_IOException()
{
- Assert.assertTrue(AWSClientUtil.isClientExceptionRecoverable(new
AmazonClientException(new IOException())));
+
Assert.assertTrue(AWSClientUtil.isClientExceptionRecoverable(SdkClientException.builder().cause(new
IOException()).build()));
}
@Test
public void testRecoverableException_RequestTimeout()
{
- AmazonServiceException ex = new AmazonServiceException(null);
- ex.setErrorCode("RequestTimeout");
+ AwsServiceException ex = AwsServiceException.builder()
+ .message("RequestTimeout")
+
.awsErrorDetails(software.amazon.awssdk.awscore.exception.AwsErrorDetails.builder()
Review Comment:
Nit: is that prefix really necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
