Fly-Style commented on code in PR #18936:
URL: https://github.com/apache/druid/pull/18936#discussion_r2721034486
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3461,6 +3461,7 @@ void maybeScaleDuringTaskRollover()
if (rolloverTaskCount > 0) {
log.info("Autoscaler recommends scaling down to [%d] tasks during
rollover", rolloverTaskCount);
changeTaskCountInIOConfig(rolloverTaskCount);
+ autoScalerConfig.setTaskCountStart(rolloverTaskCount);
Review Comment:
Config persistence works fine when on the supervisor start/stop level, but
doesn't work on the task level. Will update that too in the current PR, if
that's possible to do painlessly.
UPD: the code flow around it a bit complicated, thinking how to resolve it
properly...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
