jtuglu1 commented on code in PR #18954:
URL: https://github.com/apache/druid/pull/18954#discussion_r2735468871
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -1762,6 +1771,8 @@ public void runInternal()
checkTaskDuration();
+ maybeApplyPendingScaleRollover();
+
checkPendingCompletionTasks();
Review Comment:
Let's update the `maybeApplyPendingScaleRollover()` function comments then?
```java
* This method is called after {@link #checkPendingCompletionTasks()} to
check if a pending
* scale rollover can be applied. The scale is only applied when:
* <ul>
* <li>A pending rollover was set up in {@link #checkTaskDuration()}
(Phase 1)</li>
* <li>All actively reading task groups have stopped (moved to
pendingCompletionTaskGroups)</li>
* </ul>
* <p>
* By deferring the taskCount change until all old tasks have stopped, we
avoid
* partition allocation mismatches that would cause {@link
#discoverTasks()} to kill
* publishing tasks on the next cycle.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
