github-advanced-security[bot] commented on code in PR #18971:
URL: https://github.com/apache/druid/pull/18971#discussion_r2748546425
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/query/QueryVirtualStorageTest.java:
##########
@@ -219,6 +232,58 @@
Assertions.assertTrue(emitter.getLatestMetricEventValue(StorageMonitor.VSF_USED_BYTES,
0).longValue() > 0);
}
+ @Test
+ void testQueryTooMuchDataButWithDart()
+ {
+ // dart uses vsf in a totally rad way so it can query all of the segments
at once due to how it chunks up and
+ // fetches segments to do the work
+ final String sqlQueryId = UUID.randomUUID().toString();
+ final String resultString = cluster.callApi().onAnyBroker(
+ b -> b.submitSqlQuery(
+ new ClientSqlQuery(
+ StringUtils.format("select count(*) from \"%s\"", dataSource),
+ "CSV",
+ false,
+ false,
+ false,
+ Map.of(
+ QueryContexts.CTX_SQL_QUERY_ID, sqlQueryId,
+ QueryContexts.ENGINE, "msq-dart"
+ ),
+ null
+ )
+ )
+ ).trim();
+
+ final Long result = Long.parseLong(resultString);
Review Comment:
## Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
[Show more
details](https://github.com/apache/druid/security/code-scanning/10796)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
