kfaraz commented on code in PR #18976: URL: https://github.com/apache/druid/pull/18976#discussion_r2764885969
########## docs/ingestion/supervisor.md: ########## @@ -208,7 +208,10 @@ The following table outlines the configuration properties related to the `costBa |`lagWeight`|The weight of extracted lag value in cost function.| No| 0.25| |`idleWeight`|The weight of extracted poll idle value in cost function. | No | 0.75 | |`defaultProcessingRate`|A planned processing rate per task, required for first cost estimations. | No | 1000 | -|`scaleDownBarrier`| A number of successful scale down attempts which should be skipped to prevent the auto-scaler from scaling down tasks immediately. | No | 5 | +|`useTaskCountBoundaries`|Enables the bounded partitions-per-task window when selecting task counts.|No|`false`| Review Comment: No, I mean that since we are still in the validation phase, we should not freeze the value of the SQRT_TASK_INCREASE constant. Instead, we should allow it to be configurable for ease of testing, since we are adding a config to enable/disable it anyway. ########## docs/ingestion/supervisor.md: ########## @@ -208,7 +208,10 @@ The following table outlines the configuration properties related to the `costBa |`lagWeight`|The weight of extracted lag value in cost function.| No| 0.25| |`idleWeight`|The weight of extracted poll idle value in cost function. | No | 0.75 | |`defaultProcessingRate`|A planned processing rate per task, required for first cost estimations. | No | 1000 | -|`scaleDownBarrier`| A number of successful scale down attempts which should be skipped to prevent the auto-scaler from scaling down tasks immediately. | No | 5 | +|`useTaskCountBoundaries`|Enables the bounded partitions-per-task window when selecting task counts.|No|`false`| Review Comment: No, I mean that since we are still in the validation phase, we should not freeze the value of the SQRT_TASK_INCREASE constant. Instead, we should allow it to be configurable for ease of testing, since we are adding a config to enable/disable it anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
