jtuglu1 commented on code in PR #18891:
URL: https://github.com/apache/druid/pull/18891#discussion_r2792531268
##########
cloud/aws-common/src/main/java/org/apache/druid/common/aws/FileSessionCredentialsProvider.java:
##########
@@ -53,13 +53,12 @@ public FileSessionCredentialsProvider(String
sessionCredentialsFile)
}
@Override
- public AWSCredentials getCredentials()
+ public AwsCredentials resolveCredentials()
{
return awsSessionCredentials;
}
- @Override
- public void refresh()
+ private void refresh()
Review Comment:
This refresh() is done now solely through a preexisting scheduled on the
class. This is equivalent behavior as before, where
`FileSessionCredentialsProvider` handles its own refresh internally on its
scheduler. I don't believe the standalone method was used explicitly either;
the v1 `AWSCredentialsProviderChain` didn't proactively call refresh() on
providers during getCredentials() resolution — it just iterated through
providers catching exceptions (from what I can tell).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
