gianm commented on PR #19016:
URL: https://github.com/apache/druid/pull/19016#issuecomment-3892042166
It looks like this and #18996 are aiming at similar goals but are taking
different approaches. A big one is that #18996 only works with MSQ compaction
and this one only works with non-MSQ compaction tasks. I am wondering if they
can coexist.
re: this piece,
> MSQ compaction is fundamentally incompatible with minor compaction: it
forces dropExisting = true, uses REPLACE ingestion mode (which acquires
TIME_CHUNK locks covering the full interval), and queries via
MultipleIntervalSegmentSpec.
#18996 deals with the replace issue by using the "upgrade" system that was
introduced for concurrent replace (system from #14407, #15039, #15684). The
segments that are not being compacted are carried through without modification
("upgraded"). It deals with the MultipleIntervalSegmentSpec issue by using a
new feature in `TableInputSpec` to be able to reference specific segments
(#18922).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
