capistrant commented on PR #18939:
URL: https://github.com/apache/druid/pull/18939#issuecomment-3915373989
@clintropolis TY for the review. I made some changes based off our
conversation and off some findings during further testing. rough summary is:
* consolidated those rule types we talked about into a single schema rule
type
* did some refactoring of the "finalizer", now called "optimizer". No more
utility class full of static helpers, but rather just a single implementation
of the deletion rule optimizer which is all the cascading template needs (for
now).
* added a supervisor api for getting the timeline of search intervals and
applied rules
* added a UI for this api in the console
not directly related to your review:
* Fixed a bug in the building of the configs where the wrong segment
granularity rule was getting applied to intervals
* Changed the logic for skipOffsets, where if a skip offset calculation
lands in the middle of a search interval, it just skips compaction of that
whole interval instead of trying to truncate the interval and process part of
it. I think this simplification of that bit takes some complexity out of this
code creating the search intervals, making it a little easier to reason about.
* I also tried to break down some of the dense methods with lots of logic in
CascadingReindexingTemplate by splitting out some private methods. Some of this
was driven by the need for some re-use now that the template services the
timeline creation request from the supervisor API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
