kfaraz commented on code in PR #19028:
URL: https://github.com/apache/druid/pull/19028#discussion_r2822529158
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/CostBasedAutoScalerTest.java:
##########
@@ -454,29 +468,40 @@ public void
testComputeTaskCountForRolloverAndConfigProperties()
Assert.assertEquals(-1,
scalerWithRolloverOnly.computeTaskCountForRollover());
}
- private CostMetrics createMetrics(
- double avgPartitionLag,
- int currentTaskCount,
- int partitionCount,
- double pollIdleRatio
- )
+ @Test
+ public void testCollectMetricsReturnsNullWhenMovingAvgRateNegative()
Review Comment:
Instead of this, the test should verify that scaling action is skipped when
moving average rate is not available. The test should care less about the
internal implementation details of the target and more about its overall
behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
