abhishekrb19 commented on code in PR #19030: URL: https://github.com/apache/druid/pull/19030#discussion_r2825149530
########## docs/configuration/index.md: ########## @@ -2019,6 +2019,8 @@ log4j config to route these logs to different sources based on the feed of the e |--------|-----------|--------| |`druid.emitter.logging.loggerClass`|The class used for logging.|`org.apache.druid.java.util.emitter.core.LoggingEmitter`| |`druid.emitter.logging.logLevel`|Choices: debug, info, warn, error. The log level at which message are logged.|info| +|`druid.emitter.logging.shouldFilterMetrics`|When true, only metrics listed in the allowlist are emitted; non-metric events (e.g. alerts) are always emitted. When false, all events are logged (backward-compatible).|false| +|`druid.emitter.logging.allowedMetricsPath`|Path to a JSON file whose keys are the allowed metric names. Only used when `shouldFilterMetrics` is true. If null or empty, the bundled classpath resource `defaultMetrics.json` is used. If a path is set but the file is missing, a warning is logged and the emitter falls back to the default classpath resource.|null| Review Comment: >If a path is set but the file is missing, a warning is logged and the emitter falls back to the default classpath resource. IMO, in this case, we should fail fast by throwing an exception instead of falling back in the event of a misconfiguration, since an operator would be intentionally opting in to enable metric filtering and provide a custom path -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
