capistrant commented on code in PR #18939: URL: https://github.com/apache/druid/pull/18939#discussion_r2825693838
########## server/src/test/java/org/apache/druid/server/compaction/ReindexingTuningConfigRuleTest.java: ########## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server.compaction; + +import org.apache.druid.indexer.partitions.DynamicPartitionsSpec; +import org.apache.druid.java.util.common.DateTimes; +import org.apache.druid.java.util.common.Intervals; +import org.apache.druid.server.coordinator.UserCompactionTaskQueryTuningConfig; +import org.joda.time.DateTime; +import org.joda.time.Interval; +import org.joda.time.Period; +import org.junit.Assert; +import org.junit.Test; + +public class ReindexingTuningConfigRuleTest +{ + private static final DateTime REFERENCE_TIME = DateTimes.of("2025-12-19T12:00:00Z"); + private static final Period PERIOD_21_DAYS = Period.days(21); + + private final ReindexingTuningConfigRule rule = new ReindexingTuningConfigRule( + "test-tuning-rule", + "Custom tuning config", + PERIOD_21_DAYS, + createTestTuningConfig() + + ); + + @Test + public void test_appliesTo_intervalFullyBeforeThreshold_returnsFull() Review Comment: ya they all share. I didn't know what appropriate way was to handle this when a bunch of concrete classes share an abstract impl. cuz like you said, if someone added an impl to a concrete class, it would then be untested if we didn't have all these... but I guess that is why we have jacoco and code reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
