clintropolis commented on code in PR #19043:
URL: https://github.com/apache/druid/pull/19043#discussion_r2838463497
##########
processing/src/main/java/org/apache/druid/frame/channel/BlockingQueueFrameChannel.java:
##########
@@ -173,6 +173,8 @@ public void fail(@Nullable Throwable cause)
// If this happens, it's a bug, potentially due to incorrectly using
this class with multiple writers.
throw new ISE("Could not write error to channel");
}
+
+ notifyReader();
Review Comment:
hmm, the javadoc on `fail` says that `close` must be called after `fail`,
`close` also calls `notifyReader()`, does it matter? I guess not since it
clears the future so it would be a no-op or whatever
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
