jtuglu1 commented on code in PR #19011:
URL: https://github.com/apache/druid/pull/19011#discussion_r2843484142
##########
server/src/main/java/org/apache/druid/server/QueryLifecycle.java:
##########
@@ -134,6 +138,7 @@ public QueryLifecycle(
this.defaultQueryConfig = defaultQueryConfig;
this.authConfig = authConfig;
this.policyEnforcer = policyEnforcer;
+ this.brokerViewOfCoordinatorConfig = brokerViewOfCoordinatorConfig;
Review Comment:
nit: maybe add small comment saying this can only be `null` if not running
on the broker
##########
server/src/test/java/org/apache/druid/segment/metadata/SegmentMetadataCacheTestBase.java:
##########
@@ -292,7 +292,8 @@ public QueryLifecycleFactory
getQueryLifecycleFactory(QuerySegmentWalker walker)
new AuthConfig(),
NoopPolicyEnforcer.instance(),
AuthTestUtils.TEST_AUTHORIZER_MAPPER,
- Suppliers.ofInstance(new DefaultQueryConfig(ImmutableMap.of()))
+ Suppliers.ofInstance(new DefaultQueryConfig(ImmutableMap.of())),
Review Comment:
one more 😅 ImmutableMap -> Map.of()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
