gianm commented on a change in pull request #7203: Fix race in historical when
loading segments in parallel
URL: https://github.com/apache/incubator-druid/pull/7203#discussion_r263497471
##########
File path: server/src/main/java/org/apache/druid/server/SegmentManager.java
##########
@@ -223,6 +233,8 @@ public void dropSegment(final DataSegment segment)
final PartitionChunk<ReferenceCountingSegment> removed =
loadedIntervals.remove(
segment.getInterval(),
segment.getVersion(),
+ // remove() internally searches for a partitionChunk to remove
which is *equal* to the given
+ // partitionChunk. Note that partitionChunk.equals() checks
only the partitionNum, but not the object.
Review comment:
Thanks for adding this comment. It was a bit confusing without it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
