gianm commented on code in PR #19042:
URL: https://github.com/apache/druid/pull/19042#discussion_r2844847887
##########
multi-stage-query/src/main/java/org/apache/druid/msq/exec/std/BasicStageProcessor.java:
##########
@@ -54,4 +56,11 @@ public ExtraInfoHolder makeExtraInfoHolder(@Nullable Object
extra)
return NilExtraInfoHolder.instance();
}
+
+ @Nullable
+ @Override
+ public SegmentPruner getPruner(InputSpec inputSpec, int inputNumber)
Review Comment:
IMO this would be better as a default impl on `StageProcessor`.
##########
multi-stage-query/src/main/java/org/apache/druid/msq/indexing/processor/SegmentGeneratorStageProcessor.java:
##########
@@ -271,6 +273,13 @@ public ExtraInfoHolder makeExtraInfoHolder(final
List<SegmentIdWithShardSpec> se
return new SegmentGeneratorExtraInfoHolder(segmentIdsWithShardSpecs);
}
+ @Nullable
+ @Override
+ public SegmentPruner getPruner(InputSpec inputSpec, int inputNumber)
Review Comment:
Shouldn't be needed once the default impl is moved up to the interface.
##########
multi-stage-query/src/main/java/org/apache/druid/msq/exec/StageProcessor.java:
##########
@@ -77,4 +79,7 @@ public interface StageProcessor<R, ExtraInfoType>
*/
@SuppressWarnings("rawtypes")
ExtraInfoHolder makeExtraInfoHolder(@Nullable ExtraInfoType extra);
+
+ @Nullable
+ SegmentPruner getPruner(InputSpec inputSpec, int inputNumber);
Review Comment:
Javadocs please.
##########
multi-stage-query/src/main/java/org/apache/druid/msq/kernel/StageDefinition.java:
##########
@@ -231,6 +232,11 @@ public boolean doesSortDuringShuffle()
}
}
+ public SegmentPruner getSegmentPruner(int inputNumber)
Review Comment:
Javadoc please.
##########
multi-stage-query/src/main/java/org/apache/druid/msq/querykit/results/ExportResultsStageProcessor.java:
##########
@@ -201,6 +203,13 @@ public ExtraInfoHolder makeExtraInfoHolder(@Nullable
Object extra)
return NilExtraInfoHolder.instance();
}
+ @Nullable
+ @Override
+ public SegmentPruner getPruner(InputSpec inputSpec, int inputNumber)
Review Comment:
Should be removable once the default impl moves up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
