drcrallen commented on issue #6942: Shade Guava manually URL: https://github.com/apache/incubator-druid/issues/6942#issuecomment-470631559 Re https://github.com/apache/incubator-druid/issues/6942#issuecomment-459687733 : I do not see the alternative here. Being "stuck" on an old copy of the code is no worse than being stuck on an old version of the lib. Yes it is ad hoc because it shouldn't be normal practice. Some of the functionalities are superseded by updates to other core libraries (like in the JRE itself) and the longer term support ones should be favored. Some can be modified to use apis that have long term support from Guava (or similar libraries) and should probably do that. But for some, the only way to maintain long term support in druid is to do it ourselves. Either by straight up copying the code, or by providing some introspection mechanism. If you are worried about tracking how often we do this, maybe a 3rdparty module would suffice? We would keep code that has this kind of long-term-support wrappers in there?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
