gianm commented on code in PR #19048:
URL: https://github.com/apache/druid/pull/19048#discussion_r2876680412
##########
multi-stage-query/src/main/java/org/apache/druid/msq/indexing/IndexerWorkerContext.java:
##########
@@ -152,10 +158,12 @@ public static IndexerWorkerContext
createProductionInstance(
)
{
final IndexIO indexIO = injector.getInstance(IndexIO.class);
- final SegmentManager segmentManager = new SegmentManager(
+ final SegmentCacheManager cacheManager =
injector.getInstance(SegmentCacheManagerFactory.class)
- .manufacturate(new File(toolbox.getIndexingTmpDir(),
"segment-fetch"), true)
- );
+ .manufacturate(new File(toolbox.getIndexingTmpDir(),
"segment-fetch"), true);
+ final SegmentManager segmentManager = new SegmentManager(cacheManager);
+ final StorageMonitor storageMonitor = new StorageMonitor(cacheManager,
Map.of("taskId", task.getId(), "groupId", task.getGroupId()));
Review Comment:
Best to pass in `task::getMetricBuilder` (a supplier of
`ServiceMetricEvent.Builder`). It includes `taskId` and `groupId`, also some
other stuff like `dataSource`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
