abhishekrb19 commented on code in PR #19067:
URL: https://github.com/apache/druid/pull/19067#discussion_r2880167002
##########
server/src/main/java/org/apache/druid/server/RequestLogLine.java:
##########
@@ -76,7 +81,19 @@ public static RequestLogLine forSql(
QueryStats queryStats
)
{
- return new RequestLogLine(null, sql, sqlQueryContext, timestamp,
remoteAddr, queryStats);
+ return forSql(sql, null, sqlQueryContext, timestamp, remoteAddr,
queryStats);
+ }
+
+ public static RequestLogLine forSql(
+ String sql,
+ List<ClientSqlParameter> parameters,
Review Comment:
nit: add `@Nullable` since we explicitly pass null in the above call
##########
sql/src/main/java/org/apache/druid/sql/SqlQueryPlus.java:
##########
@@ -134,6 +136,20 @@ public List<TypedValue> parameters()
return parameters;
}
+ /**
+ * Convert parameters list to serde friendly {@link SqlParameter}
Review Comment:
```suggestion
* Convert parameters list to serde friendly {@link ClientSqlParameter}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
