clintropolis commented on code in PR #19061:
URL: https://github.com/apache/druid/pull/19061#discussion_r2893155668
##########
processing/src/main/java/org/apache/druid/timeline/partition/DimensionRangeShardSpec.java:
##########
@@ -53,13 +55,14 @@ public class DimensionRangeShardSpec extends
BaseDimensionRangeShardSpec
@JsonCreator
public DimensionRangeShardSpec(
@JsonProperty("dimensions") List<String> dimensions,
+ @JsonProperty("virtualColumns") @Nullable VirtualColumns virtualColumns,
Review Comment:
Good question i guess, i am not aware of any modules which conditionally
register expressions or custom virtual implementations not. All of the built in
expressions seemed fine at least since everything has a macro table from
expression module...
imo if someone is trying to partition by something that makes the
coordinator explode, then maybe we should fix that thing so that it doesn't
explode can load on the coordinator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
