jtuglu1 commented on code in PR #19097:
URL: https://github.com/apache/druid/pull/19097#discussion_r2894341962
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java:
##########
@@ -123,11 +122,11 @@ public void start()
TimeUnit.MILLISECONDS
);
log.info(
- "LagBasedAutoScaler will collect lag every [%d] millis and will keep
up to [%d] data points for the last [%d] millis for dataSource [%s]",
+ "LagBasedAutoScaler will collect lag every [%d] millis and will keep
up to [%d] data points for the last [%d] millis for supervisor [%s]",
Review Comment:
nit: `supervisor[%d]`
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java:
##########
@@ -245,8 +248,9 @@ private int computeDesiredTaskCount(List<Long> lags)
int actualTaskCountMax =
Math.min(lagBasedAutoScalerConfig.getTaskCountMax(), partitionCount);
if (currentActiveTaskCount == actualTaskCountMax) {
- log.debug("CurrentActiveTaskCount reached task count Max limit,
skipping scale out action for dataSource [%s].",
- dataSource
+ log.debug(
+ "CurrentActiveTaskCount reached task count Max limit, skipping
scale out action for supervisor [%s].",
Review Comment:
same nit
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java:
##########
@@ -266,8 +270,9 @@ private int computeDesiredTaskCount(List<Long> lags)
int taskCount = currentActiveTaskCount -
lagBasedAutoScalerConfig.getScaleInStep();
int actualTaskCountMin =
Math.min(lagBasedAutoScalerConfig.getTaskCountMin(), partitionCount);
if (currentActiveTaskCount == actualTaskCountMin) {
- log.debug("CurrentActiveTaskCount reached task count Min limit,
skipping scale in action for dataSource[%s].",
- dataSource
+ log.debug(
+ "CurrentActiveTaskCount reached task count Min limit, skipping
scale in action for supervisor[%s].",
Review Comment:
maybe log the min limit here since might be different from current spec's
config
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScaler.java:
##########
@@ -227,15 +230,15 @@ private int computeDesiredTaskCount(List<Long> lags)
double beyondProportion = beyond * 1.0 / metricsCount;
double withinProportion = within * 1.0 / metricsCount;
- log.debug("Calculated beyondProportion is [%s] and withinProportion is
[%s] for dataSource [%s].", beyondProportion,
- withinProportion, dataSource
+ log.debug("Calculated beyondProportion is [%s] and withinProportion is
[%s] for supervisor [%s].", beyondProportion,
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
