jtuglu1 commented on PR #19026: URL: https://github.com/apache/druid/pull/19026#issuecomment-4015321269
> Existing emitters like prometheus-emitter, dropwizard-emitter, opentsdb-emitter, etc. already have a notion of an allow list, so we’ll need to be careful not to break compatibility with them. Yes, and, ideally this can be extended so any new/existing emitter can "plugin" to the existing mechanism. > or alternatively define the interface in this patch, but only integrate it with the LoggingEmitter I'd prefer this if possible, since we'd just be deferring the unavoidable unification of all these emitters' filtering mechanisms to down-the-line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
