abhishekrb19 commented on code in PR #19011:
URL: https://github.com/apache/druid/pull/19011#discussion_r2909658206
##########
server/src/main/java/org/apache/druid/client/coordinator/CoordinatorClientImpl.java:
##########
@@ -253,6 +254,22 @@ public ListenableFuture<CoordinatorDynamicConfig>
getCoordinatorDynamicConfig()
);
}
+ @Override
+ public ListenableFuture<BrokerDynamicConfig> getBrokerDynamicConfig()
+ {
+ return FutureUtils.transform(
+ client.asyncRequest(
+ new RequestBuilder(HttpMethod.GET,
"/druid/coordinator/v1/broker/config"),
+ new BytesFullResponseHandler()
+ ),
+ holder -> JacksonUtils.readValue(
Review Comment:
Looks like this change is causing
`org.apache.druid.testing.embedded.docker.IngestionBackwardCompatibilityDockerTest`
to fail consistently (which seems like it would be a legit issue during
rolling upgrades since the Coordinators are typically upgraded in the end).
I haven’t looked closely at the surrounding code yet, but either this code
or the caller likely needs to account for the new
`/druid/coordinator/v1/broker/config` endpoint not being available on
Coordinators during rolling upgrades in a backward compatible manner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
