aho135 commented on code in PR #19110:
URL: https://github.com/apache/druid/pull/19110#discussion_r2914348686
##########
extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json:
##########
@@ -50,6 +50,8 @@
"mergeBuffer/used": { "dimensions": [], "type": "gauge", "help": "Number
of merge buffers used"},
"mergeBuffer/acquisitionTimeNs": { "dimensions": [], "type": "timer",
"help": "Total time in nanoseconds to acquire merge buffer for groupBy
queries."},
"mergeBuffer/maxAcquisitionTimeNs": { "dimensions": [], "type": "timer",
"help": "Maximum time in nanoseconds to acquire merge buffer for any single
groupBy query within the emission period."},
+ "mergeBuffer/bytesUsed" : { "dimensions": [], "type": "gauge", "help":
"Total number of bytes used by merge buffers to process groupBy queries."},
+ "mergeBuffer/maxBytesUsed" : { "dimensions": [], "type": "gauge", "help":
"Maximum number of bytes used by merge buffers for any single GroupBy query
within the emission period."},
Review Comment:
```suggestion
"mergeBuffer/maxBytesUsed" : { "dimensions": [], "type": "gauge",
"help": "Maximum number of bytes used by merge buffers for any single groupBy
query within the emission period."},
```
nit, just for consistency. Thanks @GWphua!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
