jtuglu1 commented on code in PR #18891:
URL: https://github.com/apache/druid/pull/18891#discussion_r2916015177
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/minio/ITS3ToS3ParallelIndexTest.java:
##########
@@ -40,7 +39,11 @@ public void testS3IndexData(Pair<String, List<?>>
s3InputSource) throws Exceptio
@MethodSource("resources")
public void testS3IndexData_withTempCredentials(Pair<String, List<?>>
s3InputSource) throws Exception
{
- final S3InputSourceConfig inputSourceConfig =
minIOStorageResource.createTempCredentialsForInputSource();
- doTest(s3InputSource, new Pair<>(false, false), "s3", inputSourceConfig);
+ doTestWithEndpointConfig(
Review Comment:
Oops – missed this one. There's a bunch of changes in this PR so been a bit
annoying to keep track of them.
> We should probably add a separate test method instead of updating this one.
The original test would break w/o this update. The reason is SDK v2 requires
some ARN and MinIO will basically just check whether the ARN is valid or not
(which includes needing a signing URL).
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/minio/ITS3ToS3ParallelIndexTest.java:
##########
@@ -40,7 +39,11 @@ public void testS3IndexData(Pair<String, List<?>>
s3InputSource) throws Exceptio
@MethodSource("resources")
public void testS3IndexData_withTempCredentials(Pair<String, List<?>>
s3InputSource) throws Exception
{
- final S3InputSourceConfig inputSourceConfig =
minIOStorageResource.createTempCredentialsForInputSource();
- doTest(s3InputSource, new Pair<>(false, false), "s3", inputSourceConfig);
+ doTestWithEndpointConfig(
Review Comment:
Oops – missed this one. There's a bunch of changes in this PR so been a bit
annoying to keep track of them, apologies.
> We should probably add a separate test method instead of updating this one.
The original test would break w/o this update. The reason is SDK v2 requires
some ARN and MinIO will basically just check whether the ARN is valid or not
(which includes needing a signing URL).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
