maytasm commented on PR #19141:
URL: https://github.com/apache/druid/pull/19141#issuecomment-4050736609

   > maybe this should extend InternalServerError so we can classify it? I see 
the other group by exception doesn't do this, but maybe that predates the 
exception classes
   That's not needed. SpillingGrouper.aggregate() doesn't throw the Exception. 
It returns AggregateResult with a failure reason. That will be handled 
upstream. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to