kfaraz commented on code in PR #19127:
URL: https://github.com/apache/druid/pull/19127#discussion_r2938090577
##########
server/src/main/java/org/apache/druid/discovery/DruidNodeDiscoveryProvider.java:
##########
@@ -62,14 +63,24 @@ public abstract class DruidNodeDiscoveryProvider
* Get DruidNodeDiscovery instance to discover nodes that announce given
service in its metadata.
*/
public DruidNodeDiscovery getForService(String serviceName)
+ {
+ return getForServiceAndRoles(
+ serviceName,
+ DruidNodeDiscoveryProvider.SERVICE_TO_NODE_TYPES.get(serviceName)
+ );
+ }
+
+ /**
+ * Get DruidNodeDiscovery instance to discover nodes of a specific role that
+ * announce the given service in their metadata.
+ */
+ public DruidNodeDiscovery getForServiceAndRoles(String serviceName,
Set<NodeRole> nodeRolesToWatch)
{
return serviceDiscoveryMap.computeIfAbsent(
serviceName,
Review Comment:
Thanks for catching this! Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
