jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r263625061
########## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryLimitRowIterator.java ########## @@ -70,9 +94,14 @@ public boolean hasNext() @Override public ScanResultValue next() { - ScanResultValue batch = yielder.get(); - if (ScanQuery.RESULT_FORMAT_COMPACTED_LIST.equals(resultFormat) || - ScanQuery.RESULT_FORMAT_LIST.equals(resultFormat)) { + if (ScanQuery.ResultFormat.RESULT_FORMAT_VALUE_VECTOR.equals(resultFormat)) { + throw new UOE(ScanQuery.ResultFormat.RESULT_FORMAT_VALUE_VECTOR + " is not supported yet"); + } + + // We don't want to perform batching at the historical-level if we're time ordering Review comment: Let's change the comment to match the following if block (the original "use batch" case) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org