kfaraz commented on code in PR #19016: URL: https://github.com/apache/druid/pull/19016#discussion_r2945187594
########## indexing-service/src/main/java/org/apache/druid/indexing/common/task/SpecificSegmentsSpec.java: ########## @@ -33,6 +34,13 @@ import java.util.Objects; import java.util.stream.Collectors; +/** + * Used only for native engine-based minor compaction. Review Comment: Instead of repurposing this class for native minor compaction, I would suggest we use the new `MinorCompactionInputSpec` for both native and MSQ minor compaction. (the distinction between the two would be done by the `engine` field). This would allow auto-compaction to also use native minor compaction and would help in distinguishing the new native minor compaction feature from the old segment-lock based minor compaction. It is probably better to not change the semantics of `SpecificSegmentsSpec` and deprecate it instead since it uses segment locking. ########## docs/data-management/manual-compaction.md: ########## @@ -127,16 +127,24 @@ The compaction task has two kinds of `inputSpec`: |Field|Description|Required| |-----|-----------|--------| -|`type`|Task type. Set the value to `interval`.|Yes| +|`type`|Task type. Set the value to `interval` to trigger native-engine major compaction.|Yes| |`interval`|Interval to compact.|Yes| ### Segments `inputSpec` |Field|Description|Required| |-----|-----------|--------| -|`type`|Task type. Set the value to `segments`.|Yes| +|`type`|Task type. Set the value to `segments` to trigger native-engine minor compaction.|Yes| |`segments`|A list of segment IDs.|Yes| +Note: MSQ compaction does not support segments `inputSpec`. Use `MinorCompactionInputSpec` (type: uncompacted) for MSQ minor compaction. Review Comment: ```suggestion Note: MSQ compaction does not support segments `inputSpec`. Use type `uncompacted` for MSQ minor compaction. ``` ########## docs/data-management/manual-compaction.md: ########## @@ -127,16 +127,24 @@ The compaction task has two kinds of `inputSpec`: |Field|Description|Required| |-----|-----------|--------| -|`type`|Task type. Set the value to `interval`.|Yes| +|`type`|Task type. Set the value to `interval` to trigger native-engine major compaction.|Yes| Review Comment: This isn't exactly correct since MSQ-engine major compaction would also use `interval` type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
