gianm commented on code in PR #19188:
URL: https://github.com/apache/druid/pull/19188#discussion_r2966490034
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/server/FaultyClusterTest.java:
##########
@@ -92,12 +93,21 @@ public void test_overlord_skipsCleanupOfPendingSegments()
cluster.callApi().postSupervisor(supervisorSpec);
final int recordCount = publish1kRecords(topic, true);
- waitUntilPublishedRecordsAreIngested(recordCount);
+ Assertions.assertEquals(expectedRecords, recordCount);
- cluster.callApi().postSupervisor(supervisorSpec.createSuspendedSpec());
+ waitUntilPublishedRecordsAreIngested(expectedRecords);
+
+ // Additionally, confirm that rows were placed into Druid.
+ // Caution: "ingest/rows/output" does not have a 'DATASOURCE' dimension.
+ indexer.latchableEmitter().waitForEventAggregate(
+ event -> event.hasMetricName("ingest/rows/output"),
Review Comment:
This isn't necessary now that #19177 is published, since
`waitUntilPublishedRecordsAreIngested` will check the new metric
`ingest/rows/published`. This one is even better than `ingest/rows/output`.
(`ingest/rows/output` is emitted when we persist to local disk,
`ingest/rows/published` is emitted when we persist to S3 and add a record to
the metadata store, meaning the ingestion is truly done).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
