gianm commented on code in PR #18851:
URL: https://github.com/apache/druid/pull/18851#discussion_r2968323165
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunnerResource.java:
##########
@@ -124,7 +124,7 @@ public Response getWorkersWithUnacknowledgedTasks()
return
Response.status(Response.Status.FORBIDDEN).entity("HttpRemoteTaskRunner is
NULL.").build();
}
- return
Response.ok().entity(httpRemoteTaskRunner.getWorkersWithUnacknowledgedTasks()).build();
+ return
Response.ok().entity(httpRemoteTaskRunner.getPendingAssignWorkers()).build();
Review Comment:
Am I reading it right? Looks like the old
`getWorkersWithUnacknowledgedTasks` returns `Map<String, String>`, the new
`getPendingAssignWorkers` returns `Collection<ImmutableWorkerInfo>`. The
response would change from a key-value object to an array of info objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
