abhishekrb19 commented on code in PR #19198:
URL: https://github.com/apache/druid/pull/19198#discussion_r2976792536


##########
docs/ingestion/ingestion-spec.md:
##########
@@ -243,7 +243,7 @@ Dimension objects can have the following components:
 | name | The name of the dimension. This will be used as the field name to 
read from input records, as well as the column name stored in generated 
segments.<br /><br />Note that you can use a [`transformSpec`](#transformspec) 
if you want to rename columns during ingestion time. | none (required) |
 | createBitmapIndex | For `string` typed dimensions, whether or not bitmap 
indexes should be created for the column in generated segments. Creating a 
bitmap index requires more storage, but speeds up certain kinds of filtering 
(especially equality and prefix filtering). Only supported for `string` typed 
dimensions. | `true` |
 | multiValueHandling | For `string` typed dimensions, specifies the type of 
handling for [multi-value fields](../querying/multi-value-dimensions.md). 
Possible values are `array` (ingest string arrays as-is), `sorted_array` (sort 
string arrays during ingestion), and `sorted_set` (sort and de-duplicate string 
arrays during ingestion). This parameter is ignored for types other than 
`string`. | `sorted_array` |
-| maxStringLength | For `string` typed dimensions, the maximum number of 
characters to store per value. Longer values are truncated during ingestion. 
Does not apply to multi-value string dimensions. Set to 0 to disable. Overrides 
the global 
[`druid.indexing.formats.maxStringLength`](../configuration/index.md#additional-peon-configuration)
 property. | `0` (no truncation) |
+| maxStringLength | For `string` typed dimensions, the maximum number of 
characters to store per value. Longer values are truncated during ingestion. 
Does not apply to multi-value string dimensions. Overrides the global 
[`druid.indexing.formats.maxStringLength`](../configuration/index.md#additional-peon-configuration)
 property. | `null` (no truncation) |

Review Comment:
   ```suggestion
   | maxStringLength | For `string` typed dimensions, the maximum number of 
characters to store per value. Longer values are truncated during ingestion. 
Does not apply to multi-value string dimensions. Overrides the global 
[`druid.indexing.formats.maxStringLength`](../configuration/index.md#additional-peon-configuration)
 property.  Value must be >= 0.| `null` (no truncation) |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to