capistrant commented on code in PR #19106:
URL: https://github.com/apache/druid/pull/19106#discussion_r2991253223
##########
indexing-service/src/main/java/org/apache/druid/indexing/compact/CascadingReindexingTemplate.java:
##########
@@ -123,11 +134,24 @@ public CascadingReindexingTemplate(
InvalidInput.conditionalException(defaultSegmentGranularity != null,
"'defaultSegmentGranularity' cannot be null");
this.defaultSegmentGranularity = defaultSegmentGranularity;
+ InvalidInput.conditionalException(defaultPartitionsSpec != null,
"'defaultPartitionsSpec' cannot be null");
+ this.defaultPartitionsSpec = defaultPartitionsSpec;
+
+ this.defaultPartitioningVirtualColumns = defaultPartitioningVirtualColumns;
+
+ this.tuningConfig = tuningConfig;
+
if (skipOffsetFromNow != null && skipOffsetFromLatest != null) {
throw InvalidInput.exception("Cannot set both skipOffsetFromNow and
skipOffsetFromLatest");
}
this.skipOffsetFromNow = skipOffsetFromNow;
this.skipOffsetFromLatest = skipOffsetFromLatest;
+
+ this.defaultPartitioningRule = ReindexingPartitioningRule.syntheticRule(
+ defaultSegmentGranularity,
+ defaultPartitionsSpec,
+ defaultPartitioningVirtualColumns
+ );
Review Comment:
after reflecting, I think failing with clear error on trying to use
unsupported field in the static tuningConfig is ok and right way to head off
operator confusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
