leventov commented on issue #6942: Shade Guava manually URL: https://github.com/apache/incubator-druid/issues/6942#issuecomment-471092369 > And it gives users more control over what Guava version they run. In the approach that I suggested, we *also* depending on Guava 16.0.1, letting users to substitute Guava for other dependencies and third-party code users combine Druid with in their private builds, but not the Druid code itself. I don't really imagine why users may want to substitute the use of latest Guava in Druid code itself with use of some older version, except that if there is some regression in the latest Guava source, but that should then be considered a bug in Druid and fixed as a normal bug (since we control the source). But this is a very, very unlikely situation. @gianm, your analysis also misses the main point and the advantage of the approach that I suggested: we are able to use latest Guava features, such as MoreCollectors, and more. I had to explain this earlier in the thread.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
