maytasm commented on code in PR #19357:
URL: https://github.com/apache/druid/pull/19357#discussion_r3192727929
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/SpillingGrouper.java:
##########
@@ -293,6 +320,22 @@ public void setSpillingAllowed(final boolean
spillingAllowed)
@Override
public CloseableIterator<Entry<KeyType>> iterator(final boolean sorted)
{
+ // Flush any runs that did not reach MIN_SPILL_FILE_BYTES during the spill
phase.
+ try {
+ flushPendingRunsToDisk();
Review Comment:
Looks like the reason iterator(true) is hardcoded in
RowBasedGrouperHelper:634 is that the merge layer above it relies on sorted
input — CombiningIterator in ConcurrentGrouper and the broker merge both detect
duplicate keys by comparing consecutive sorted entries. So sorted=true is for
merge correctness, not output ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
