capistrant commented on code in PR #19409:
URL: https://github.com/apache/druid/pull/19409#discussion_r3204875738
##########
server/src/main/java/org/apache/druid/server/coordinator/rules/PartialLoadRule.java:
##########
@@ -89,9 +90,21 @@ public boolean appliesTo(DataSegment segment, DateTime
referenceTimestamp)
@Override
public void run(DataSegment segment, SegmentActionHandler handler)
{
- // Partial plumbing is added in future work. For now, a partial rule that
applies to a segment full-loads it,
- // identical behavior to the corresponding non-partial rule
- handler.replicateSegment(segment, getTieredReplicants());
+ final PartialLoadMatcher.MatchResult result = matcher.match(segment,
segment.getLoadSpec());
+ if (result != null) {
+ // Matcher resolved: route through the partial-load handler. The
wrappedLoadSpec map carries scheme-specific
+ // data that the historical-side wrapper deserializes.
+ handler.replicateSegmentPartially(
Review Comment:
not ideal but since I don't have other comments requiring fixup and you plan
to fast follow, I think this is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
