leventov commented on a change in pull request #7088: Improve parallelism of 
zookeeper based segment change processing
URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264442741
 
 

 ##########
 File path: 
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java
 ##########
 @@ -75,6 +75,36 @@ public String getLoadQueuePeonType()
     return "curator";
   }
 
+  @Config("druid.coordinator.loadqueuepeon.curator.numCreateThreads")
+  public int getCreateZkNodeNumThreads()
 
 Review comment:
   @egor-ryashin What do you think about keeping the "Num" part? [This 
book](https://www.amazon.com/Art-Readable-Code-Practical-Techniques-ebook/dp/B0064CZ1XE)
 advocates for using the "numSomething" naming and after reading it I changed 
my former preference of calling things in plural (like `threads`) to 
`numThreads`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to