jtuglu1 commented on code in PR #19431:
URL: https://github.com/apache/druid/pull/19431#discussion_r3222065463
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -4279,17 +4318,8 @@ private OrderedSequenceNumber<SequenceOffsetType>
getOffsetFromStorageForPartiti
if (!taskTuningConfig.isSkipSequenceNumberAvailabilityCheck()) {
if (!checkOffsetAvailability(partition, sequence)) {
if (taskTuningConfig.isResetOffsetAutomatically()) {
- resetInternal(
- createDataSourceMetaDataForReset(ioConfig.getStream(),
ImmutableMap.of(partition, sequence))
- );
- throw new StreamException(
- new ISE(
- "Previous sequenceNumber [%s] is no longer available for
partition [%s] - automatically resetting"
- + " sequence",
- sequence,
- partition
- )
- );
+ partitionsToReset.put(partition, sequence);
Review Comment:
We do – that's the point of this change. Throw one big exception instead of
N smaller ones that delay the progress of the supervisor. The big exception
currently omits sequences (only includes partition #s). I generally never need
to look at the partition #s unless supervisor doesn't have auto-reset on, but
we can make sure those #s are logged as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
