FrankChen021 commented on code in PR #19451: URL: https://github.com/apache/druid/pull/19451#discussion_r3226690319
########## server/src/main/java/org/apache/druid/segment/loading/StorageLocationStats.java: ########## @@ -27,12 +27,25 @@ public interface StorageLocationStats long getUsedBytes(); /** - * Number of load operations during the measurement period + * Number of load operations that were started (space reserved) during the measurement period. This is incremented + * when the load begins, regardless of whether it ultimately completes. + */ + long getLoadBeginCount(); Review Comment: [P2] Keep storage stats interfaces source compatible This adds new abstract methods to a public stats interface returned by SegmentCacheManager.getStorageStats(). Any extension or custom SegmentCacheManager that provides its own StorageLocationStats implementation will now fail to compile, or can hit AbstractMethodError when StorageMonitor invokes the new methods. Since implementations without begin-metric data can report zero, make these default methods returning 0 and apply the same compatibility treatment to VirtualStorageLocationStats. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
