abhishekrb19 opened a new pull request, #19457:
URL: https://github.com/apache/druid/pull/19457
Summary
- Converts `QueryBlocklistRule` from a concrete class to an interface with
two methods: `getRuleName()` and `matches(Query<?>)`.
- Moves the existing implementation to `DefaultQueryBlocklistRule` with a
default impl on the interface `@JsonTypeInfo(defaultImpl =
DefaultQueryBlocklistRule.class)` so existing JSON configs without a "type"
field continue to deserialize correctly.
- Extensions can register new rule types as Jackson subtypes via
SimpleModule.registerSubtypes(...) and we can even introduce new union rule
types with different logic w/o polluting existing default implementation.
**Motivation**
The current blocklist logic is fixed to datasource/queryType/context
matching. Making it an interface allows adding new rule types (e.g.,
regex-based, time-window-based, user-based) without modifying the existing code.
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [x] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
