This is an automated email from the ASF dual-hosted git repository.
gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new dcfca03 More accurate RealtimeMetricsMonitor messages. (#7230)
dcfca03 is described below
commit dcfca0371826fd756af0e354c01cc8a81fe24301
Author: Gian Merlino <[email protected]>
AuthorDate: Mon Mar 11 19:50:32 2019 -0400
More accurate RealtimeMetricsMonitor messages. (#7230)
The old messages did not reflect the full range of reasons why messages
could be thrown away.
---
.../indexing/common/stats/TaskRealtimeMetricsMonitor.java | 10 +++++++---
.../apache/druid/segment/realtime/RealtimeMetricsMonitor.java | 10 ++++++++--
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git
a/indexing-service/src/main/java/org/apache/druid/indexing/common/stats/TaskRealtimeMetricsMonitor.java
b/indexing-service/src/main/java/org/apache/druid/indexing/common/stats/TaskRealtimeMetricsMonitor.java
index 77fc462..ed1cff0 100644
---
a/indexing-service/src/main/java/org/apache/druid/indexing/common/stats/TaskRealtimeMetricsMonitor.java
+++
b/indexing-service/src/main/java/org/apache/druid/indexing/common/stats/TaskRealtimeMetricsMonitor.java
@@ -73,13 +73,17 @@ public class TaskRealtimeMetricsMonitor extends
AbstractMonitor
final long thrownAway = rowIngestionMetersTotals.getThrownAway() -
previousRowIngestionMetersTotals.getThrownAway();
if (thrownAway > 0) {
- log.warn("[%,d] events thrown away because they are outside the window
period!", thrownAway);
+ log.warn(
+ "[%,d] events thrown away. Possible causes: null events, events
filtered out by transformSpec, or events outside earlyMessageRejectionPeriod /
lateMessageRejectionPeriod.",
+ thrownAway
+ );
}
emitter.emit(builder.build("ingest/events/thrownAway", thrownAway));
- final long unparseable = rowIngestionMetersTotals.getUnparseable() -
previousRowIngestionMetersTotals.getUnparseable();
+ final long unparseable = rowIngestionMetersTotals.getUnparseable()
+ -
previousRowIngestionMetersTotals.getUnparseable();
if (unparseable > 0) {
- log.error("[%,d] Unparseable events! Turn on debug logging to see
exception stack trace.", unparseable);
+ log.error("[%,d] unparseable events discarded. Turn on debug logging to
see exception stack trace.", unparseable);
}
emitter.emit(builder.build("ingest/events/unparseable", unparseable));
diff --git
a/server/src/main/java/org/apache/druid/segment/realtime/RealtimeMetricsMonitor.java
b/server/src/main/java/org/apache/druid/segment/realtime/RealtimeMetricsMonitor.java
index 4768ca9..9fd5797 100644
---
a/server/src/main/java/org/apache/druid/segment/realtime/RealtimeMetricsMonitor.java
+++
b/server/src/main/java/org/apache/druid/segment/realtime/RealtimeMetricsMonitor.java
@@ -76,12 +76,18 @@ public class RealtimeMetricsMonitor extends AbstractMonitor
final long thrownAway = metrics.thrownAway() - previous.thrownAway();
if (thrownAway > 0) {
- log.warn("[%,d] events thrown away because they are outside the window
period!", thrownAway);
+ log.warn(
+ "[%,d] events thrown away. Possible causes: null events, events
filtered out by transformSpec, or events outside windowPeriod.",
+ thrownAway
+ );
}
emitter.emit(builder.build("ingest/events/thrownAway", thrownAway));
final long unparseable = metrics.unparseable() - previous.unparseable();
if (unparseable > 0) {
- log.error("[%,d] Unparseable events! Turn on debug logging to see
exception stack trace.", unparseable);
+ log.error(
+ "[%,d] unparseable events discarded. Turn on debug logging to see
exception stack trace.",
+ unparseable
+ );
}
emitter.emit(builder.build("ingest/events/unparseable", unparseable));
final long dedup = metrics.dedup() - previous.dedup();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
