FrankChen021 commented on code in PR #19466:
URL: https://github.com/apache/druid/pull/19466#discussion_r3252854725
##########
.asf.yaml:
##########
@@ -25,6 +25,19 @@ github:
edit_comment_discussion: "Re: [D] {title} ({repository})"
delete_comment_discussion: "Re: [D] {title} ({repository})"
+ rulesets:
+ - name: "Default Branch Protection"
+ type: branch
+ branches:
+ includes:
+ - "~DEFAULT_BRANCH"
+ - "release/*"
Review Comment:
[P1] Release branch ruleset misses Druid release branches
The ruleset only includes `~DEFAULT_BRANCH`, `release/*`, and `rel/*`, but
Druid's release process names release branches as bare versions such as
`0.17.0` and `24.0.0`, and the repository already has version-named release
refs. As written, the new deletion and force-push protections will not apply to
those release branches, which defeats the PR's stated goal of protecting
default and release branches. Please add a pattern that matches Druid's
version-named release branches, or otherwise align the ruleset with the
project's release branch naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
