GWphua commented on PR #19484: URL: https://github.com/apache/druid/pull/19484#issuecomment-4497144242
Hi @jtuglu1 I looked at trying to test the regression, but this may break abstraction. I am looking to bring these 3 lines of code into a function `reportSegmentMetrics(QueryMetrics<?>, SegmentMetrics)`. ``` queryMetrics.reportSegmentTime(segmentMetrics.getSegmentTime()); queryMetrics.reportWaitTime(segmentMetrics.getWaitTime()); queryMetrics.reportSegmentAndCacheTime(segmentMetrics.getSegmentAndCacheTime()); ``` However, the `SegmentMetrics` class is nested within the private query runner. Given that the fix removes the fall-through switch and replaces it with direct reporter-to-value calls, I think that it is ok to omit the tests. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
